Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion (Plugin)]: Competition Refactor #443

Open
sarhatabaot opened this issue Sep 27, 2024 · 1 comment
Open

[Suggestion (Plugin)]: Competition Refactor #443

sarhatabaot opened this issue Sep 27, 2024 · 1 comment
Labels
suggestion: plugin A suggestion for the plugin.

Comments

@sarhatabaot
Copy link
Collaborator

Suggestion

We should refactor the Competition class file.
It does too many things at once. Each competition type should be implemented in a different class file.
I don't really have time to implement this so leaving this issue open so we don't forget.

@sarhatabaot sarhatabaot added the suggestion: plugin A suggestion for the plugin. label Sep 27, 2024
@FireML
Copy link
Contributor

FireML commented Sep 28, 2024

My suggestions:

  • Split the Leaderboard class between each competition type
  • Move the applyToLeaderboard method to the Leaderboard class
  • Move the sendPlayerLeaderboard method to the Leaderboard class (and sendConsoleLeaderboard, but these should probably be merged for cleanliness)
  • Add a getChatMessage to the Leaderboard class, which is used by the sendPlayerLeaderboard and can be used elsewhere if needed

These are all for the leaderboard, but will help the Competition classes look better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion: plugin A suggestion for the plugin.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants