Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Battle music continues after battle completed #143

Open
OnlineCop opened this issue Aug 19, 2022 · 1 comment
Open

Battle music continues after battle completed #143

OnlineCop opened this issue Aug 19, 2022 · 1 comment

Comments

@OnlineCop
Copy link
Owner

I've noticed that the map's music plays as the player walks around, and the battle music starts as soon as a battle begins.

Once the battle ends, the battle music continues to play instead of resetting to the map music.

@pedro-w
Copy link
Contributor

pedro-w commented Aug 20, 2022

There was some kind of 'stack' system for music players when we were using DUMB, which didn't translate to the way SDL_mixer works. I suppose we need to re-instate something like that. I think if the map track restarted from the beginning after combat, that wouldn't be a big deal?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants