Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[csolution] Extend processor attributes #1149

Closed
brondani opened this issue Oct 12, 2023 · 3 comments
Closed

[csolution] Extend processor attributes #1149

brondani opened this issue Oct 12, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@brondani
Copy link
Collaborator

brondani commented Oct 12, 2023

With the advent of CMSIS-DFP where each device is described only with a single superset entry containing all features enabled, for using subset variants the expectation is to leave it to project settings to disable/change features.

For allowing the device features selection I am proposing to extend the processor attributes with the following items:

@brondani brondani added the enhancement New feature or request label Oct 12, 2023
@edriouk
Copy link
Collaborator

edriouk commented Oct 12, 2023

I would suggest using not only CMSIS enums, but also attributes from pdsc:

Dfpu: NO_FPU, SP_FPU, DP_FPU - DfpuEnum
Ddsp: DSP, NO_DSP - DdspEnum
Dmve: NO_MVE, MVE, FP_MVE - DmveEnum
Dndian: Little-endian, Little-endian - DendianEnum

This has the following advantages:

  • consistent with pack description
  • consistent with RTE Model usage
  • no need to convert name and values => can directly be passed to condition evaluation
  • future attributes can be also supported without need to change a tool

@brondani
Copy link
Collaborator Author

brondani commented Nov 8, 2023

Implemented in #1191
@ReinhardKeil can you please update the documentation?
The schema descriptions can be found here:
https://github.com/Open-CMSIS-Pack/devtools/pull/1191/files#diff-2fed5eb3550b2bc74902a4863e1a4efc35f995e27d2b4ddecf1c1620e1b3fd29

@brondani brondani moved this from In Progress to Done in CMSIS-Toolbox 2.2.0 Nov 8, 2023
@ReinhardKeil
Copy link
Collaborator

Documented here https://github.com/Open-CMSIS-Pack/cmsis-toolbox/blob/main/docs/YML-Input-Format.md#processor

I think this can then be closed. endian is not documented as I don't know any use case.

@jkrech jkrech closed this as completed Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

4 participants