Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

com_msg_request_cancellation operation_id field #9

Open
OSFO opened this issue Sep 16, 2015 · 3 comments
Open

com_msg_request_cancellation operation_id field #9

OSFO opened this issue Sep 16, 2015 · 3 comments

Comments

@OSFO
Copy link

OSFO commented Sep 16, 2015

Hi,
I am having problems getting the TEE_GetCancellationFlag functionality to work.

To me it seems that the operation_id field of the com_msg_request_cancellation is never set - however it is later compared in request_cancel_msg.

Hope I am not terribly of base here...

@TanelDettenborn
Copy link
Member

Hi, Our cancellation functionality did work, but it may have been broken.
I will look into this problem and getting back to you.

2015-09-16 17:21 GMT+03:00 OSFO [email protected]:

Hi,
I am having problems getting the TEE_GetCancellationFlag functionality to
work.

To me it seems that the operation_id field of the
com_msg_request_cancellation is never set - however it is later compared
in request_cancel_msg.

Hope I am not terribly of base here...


Reply to this email directly or view it on GitHub
#9.

@TanelDettenborn
Copy link
Member

You are not at all terribly of base here. You are absolutely right,
operation_id filed is not set, but it is used at TA.
I have made a patch: https://review.gerrithub.io/#/c/246717/
If the patch is OK, then it is merged into master.

If there is anything else, do not hesitate =)

Sorry about inconvenience.

2015-09-17 12:07 GMT+03:00 Tanel Dettenborn [email protected]:

Hi, Our cancellation functionality did work, but it may have been broken.
I will look into this problem and getting back to you.

2015-09-16 17:21 GMT+03:00 OSFO [email protected]:

Hi,
I am having problems getting the TEE_GetCancellationFlag functionality
to work.

To me it seems that the operation_id field of the
com_msg_request_cancellation is never set - however it is later compared
in request_cancel_msg.

Hope I am not terribly of base here...


Reply to this email directly or view it on GitHub
#9.

@OSFO
Copy link
Author

OSFO commented Sep 17, 2015

Works great - thanks!

You guys are fast as lightening...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants