Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When skipping checks due to a label, update existing statuses if present #38

Open
astrofrog opened this issue Nov 22, 2018 · 1 comment
Labels
bug Something isn't working

Comments

@astrofrog
Copy link
Collaborator

When skipping checks, we currently post to the single status with the bot name (no e.g. :changelog):

            if skip_fails:
                pr_handler.set_status('failure', "Skipping checks due to {0} label".format(label), current_app.bot_username)

However, if post_comment is False and there are already individual status checks (e.g. astropy-bot:changelog) we should mark those as skipped instead of creating a astropy-bot status.

@astrofrog astrofrog added the bug Something isn't working label Nov 22, 2018
@pllim
Copy link
Contributor

pllim commented Dec 7, 2018

Where is this code? I failed to "grep" it from master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants