Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a reason why all 3 checks are in 1 job? #78

Open
pllim opened this issue Jun 20, 2019 · 5 comments
Open

Is there a reason why all 3 checks are in 1 job? #78

pllim opened this issue Jun 20, 2019 · 5 comments
Labels
question Further information is requested

Comments

@pllim
Copy link
Contributor

pllim commented Jun 20, 2019

When one of the jobs fail, it is hard to see immediately which one. Should these be 3 separate jobs in a matrix?

  • Unit tests
  • PEP 8
  • Doc build
@pllim pllim added the question Further information is requested label Jun 20, 2019
@astrofrog
Copy link
Collaborator

Trying to reduce ecological footprint from having to spin up 3 VMs for such a small package :) But seriously though, feel free to split.

@pllim
Copy link
Contributor Author

pllim commented Jun 20, 2019

Now that you guilt trip me like that, I am not sure how to respond. Haha. 🤔

@astrofrog
Copy link
Collaborator

Sorry for the 🇬🇧 reply 😉 - actually I don't know if it really matters if we split it or not in terms of build time/energy, I wasn't really being serious above.

@pllim
Copy link
Contributor Author

pllim commented Jun 21, 2019

Do you wanna try out Azure here? 🤔

@pllim
Copy link
Contributor Author

pllim commented Jun 21, 2019

I am thinking... if we going to split the job anyway, it is not too much more work to just do it in azure-pipelines.yml. (Not a 🇬🇧 reply.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants