-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update external link taps to Link widget #2
Comments
can you assign this issue to me? |
We are glad that you have decided to contribute to our repositories. Since you are the first one here, this issue will be assigned to you. We will start assigning issues from the 1st of October when Hacktoberfest starts. Happy coding. Make sure you have completed the checklist
|
@karanpatel2329 just checking in if you are working on this. Please reply to this comment to mark your participation. Reach out to us on community channels if you face issue setting up the project |
@karanpatel2329, due to inactivity we are unassigning this issue as of now |
Let me handle this ASAP as well. |
if I understood the task, you need me to use this url_launcher package right ? |
I will even create an extension for it. |
@Codesait please refer to the Link api guide given in the issue description. Url launching code is already present. You need to modify it to use Link widget |
This is an example code as to how to use link widget |
I have assigned the issue to you. @Codesait Happy contributing |
@Codesait make sure you are using Target as blank |
I will love more description to this task as well 🙏🏽. Just more clarity or a simple way to identify, where to make this necessary changes. I don't think you want me to change all GestureDetector occurrences to link widget ?? |
Sorry for the late reply, I am out of station. Will update the details in 2-3 days, once I return |
Flutter 2.0 introduced the link widget which provides advanced fidelity for web platform. All code that use internal Gesture detector to be changed to Link Widget.
Link class api guide
https://pub.dev/documentation/url_launcher/latest/link/Link-class.html
The text was updated successfully, but these errors were encountered: