Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update external link taps to Link widget #2

Open
shatanikmahanty opened this issue Feb 8, 2022 · 13 comments
Open

Update external link taps to Link widget #2

shatanikmahanty opened this issue Feb 8, 2022 · 13 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hactoberfest This label marks the involvement of entity with hacktoberfest Up for grabs This is available to be worked upon

Comments

@shatanikmahanty
Copy link
Member

shatanikmahanty commented Feb 8, 2022

Flutter 2.0 introduced the link widget which provides advanced fidelity for web platform. All code that use internal Gesture detector to be changed to Link Widget.

Link class api guide

https://pub.dev/documentation/url_launcher/latest/link/Link-class.html

@shatanikmahanty shatanikmahanty added enhancement New feature or request good first issue Good for newcomers labels Feb 8, 2022
@shatanikmahanty shatanikmahanty added hactoberfest This label marks the involvement of entity with hacktoberfest Up for grabs This is available to be worked upon labels Sep 26, 2022
@karanpatel2329
Copy link

can you assign this issue to me?

@shatanikmahanty
Copy link
Member Author

shatanikmahanty commented Sep 28, 2022

can you assign this issue to me?

We are glad that you have decided to contribute to our repositories. Since you are the first one here, this issue will be assigned to you. We will start assigning issues from the 1st of October when Hacktoberfest starts. Happy coding.

Make sure you have completed the checklist

@shatanikmahanty shatanikmahanty removed the Up for grabs This is available to be worked upon label Sep 28, 2022
@shatanikmahanty
Copy link
Member Author

@karanpatel2329 just checking in if you are working on this. Please reply to this comment to mark your participation. Reach out to us on community channels if you face issue setting up the project

@shatanikmahanty shatanikmahanty added the Up for grabs This is available to be worked upon label Oct 19, 2022
@shatanikmahanty
Copy link
Member Author

@karanpatel2329, due to inactivity we are unassigning this issue as of now

@Codesait
Copy link
Contributor

Let me handle this ASAP as well.

@Codesait
Copy link
Contributor

if I understood the task, you need me to use this url_launcher package right ?

@Codesait
Copy link
Contributor

I will even create an extension for it.

@shatanikmahanty
Copy link
Member Author

shatanikmahanty commented Oct 21, 2022

if I understood the task, you need me to use this url_launcher package right ?

@Codesait please refer to the Link api guide given in the issue description. Url launching code is already present. You need to modify it to use Link widget

@shatanikmahanty
Copy link
Member Author

shatanikmahanty commented Oct 21, 2022

Link(
      uri: Uri.parse('https://flatteredwithflutter.com'),
      builder: (_, followLink) {
       return ElevatedButton(
        onPressed: followLink,
        child: Text('Click me!!'),
     );
   },
);

This is an example code as to how to use link widget

@shatanikmahanty
Copy link
Member Author

I have assigned the issue to you. @Codesait Happy contributing

@shatanikmahanty
Copy link
Member Author

@Codesait make sure you are using Target as blank

@Codesait
Copy link
Contributor

I will love more description to this task as well 🙏🏽.

Just more clarity or a simple way to identify, where to make this necessary changes.

I don't think you want me to change all GestureDetector occurrences to link widget ??

@shatanikmahanty
Copy link
Member Author

I will love more description to this task as well 🙏🏽.

Just more clarity or a simple way to identify, where to make this necessary changes.

I don't think you want me to change all GestureDetector occurrences to link widget ??

Sorry for the late reply, I am out of station. Will update the details in 2-3 days, once I return

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hactoberfest This label marks the involvement of entity with hacktoberfest Up for grabs This is available to be worked upon
Projects
None yet
Development

No branches or pull requests

3 participants