Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unique ID to all signed requests, or use an alternative memoization approach #44

Open
adewes opened this issue Dec 7, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@adewes
Copy link
Member

adewes commented Dec 7, 2021

Currently it is still possible for an adversary to perform a replay attack during the short time frame covered by the timestamp validity period of signed requests. We can mitigate this risk by adding a unique ID to signed requests on the client side and storing that ID in a short-lived data structure in the backend, rejecting requests based on the ID value. Alternatively we can just hash the signed data and reject requests for signed data with the same hash.

Storage of these hashes can be very short-lived as we only need to retain them during the validity period of the given signed request.

@adewes adewes added the enhancement New feature or request label Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant