Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Decon block sell order to PBS market #409

Open
MikeJeffers opened this issue Oct 10, 2021 · 1 comment
Open

Add Decon block sell order to PBS market #409

MikeJeffers opened this issue Oct 10, 2021 · 1 comment
Assignees
@Junelicious
Labels
Difficulty: Easy This issue would be easy to do, and has little uncertainty in scope and implementation enhancement New feature or request Gamma This issue or PR has to do with Gamma good first issue Good for newcomers Priority: High This ticket needs to be completed asap Refactor Code maintainability, style, or other non-functional changes

Comments

@MikeJeffers
Copy link

https://github.com/OpenPerpetuum/PerpetuumServer/blob/Development/src/Perpetuum/Zones/PBS/DockingBases/PBSDockingBase.cs#L172
This adds plasma, among other things.
Add decon blocks to this.

Bonus: fix the lookups to be more robust to definition changes or new definitions.
Cache/or use EntityDefaults static collections to find and store plasma, blocks, and other orders and find their definition ints to do lookups by - avoid hardcoded values!
@MikeJeffers MikeJeffers added enhancement New feature or request good first issue Good for newcomers Gamma This issue or PR has to do with Gamma Refactor Code maintainability, style, or other non-functional changes labels Oct 10, 2021
@MikeJeffers
Copy link
Author

This can be tested by building a PBS docking base on a gamma island and reviewing the orders that get inserted to the market after it is constructed.

@MikeJeffers MikeJeffers added Difficulty: Easy This issue would be easy to do, and has little uncertainty in scope and implementation Priority: High This ticket needs to be completed asap labels Oct 29, 2021
@Junelicious Junelicious self-assigned this Nov 17, 2021
@clouths clouths moved this to In progress in Game Server Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Junelicious Junelicious

Labels
Difficulty: Easy This issue would be easy to do, and has little uncertainty in scope and implementation enhancement New feature or request Gamma This issue or PR has to do with Gamma good first issue Good for newcomers Priority: High This ticket needs to be completed asap Refactor Code maintainability, style, or other non-functional changes
Projects
Game Server
Status: In progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MikeJeffers @Junelicious