Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split tests into individual jobs. #20

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

sobomax
Copy link
Contributor

@sobomax sobomax commented Nov 24, 2023

This is part II of two part PR (the other part is in the OpenSIPS/sipssert-opensips-tests repo). It basically splits one monolithic job into individual scenarios to run in parallel. This has the following benefits:

  • Test complete much faster. From 30 minutes down to 6-7 minutes;
  • Logs are split on per-scenario basis making debugging much easier;
  • If one of many scenarios fail, it's very obviously where it fails;
  • Different OS/OpenSIPS versions can be tested in parallel if needed.
  • The matrix is controlled by the matrix.yml file in the root of the tests repo.

ScreenShot1138
ScreenShot1139

@sobomax
Copy link
Contributor Author

sobomax commented Nov 24, 2023

P.S. The action would fail until both parts are merged.

@razvancrainea
Copy link
Member

@sobomax this is a great idea, thanks for setting it up!
My only question is whether it chances the way the action is triggered by the other actions/projects.

@sobomax
Copy link
Contributor Author

sobomax commented Nov 24, 2023

@sobomax this is a great idea, thanks for setting it up! My only question is whether it chances the way the action is triggered by the other actions/projects.

If they use Run_All_Tests then no, the script would work as before. But if they forked out tests and did not make any changes into tests/.github/workflows/run-tests.yml then it should work too (may need to update matrix for any tests not present).

@razvancrainea razvancrainea merged commit 40a9dc6 into OpenSIPS:main Nov 24, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants