add healthcheck #22
add healthcheck #22
Conversation
|
Thank you for the contribution! The idea is great, the only problem is that the existence of |
| @@ -22,7 +22,7 @@ RUN apt-get -y update -qq && \ | |||
| apt-get -y install \ | |||
| opensips${OPENSIPS_VERSION_MINOR:+=$OPENSIPS_VERSION.$OPENSIPS_VERSION_MINOR-$OPENSIPS_VERSION_REVISION} | |||
|
|
|||
| ARG OPENSIPS_CLI=false | |||
| ARG OPENSIPS_CLI=true | |||
There was a problem hiding this comment.
unfortunately this is not the correct fix, as one might compile it with OPENSIPS_CLI=false - for example this is how we build the sipssert image.
The correct fix would be to exit 1 if OPENSIPS_CLI is false, or skip the healthcheck altoghether - not sure that is possible though
There was a problem hiding this comment.
You are correct. If OPENSIPS_CLI is false, and if the opensips-cli is not installed, I don't know of any other way to perform healthcheck. Please forgive me, my English is not very good.
There was a problem hiding this comment.
Please keep the PR open, as soon as I have some time, I will try to adapt it myself :).
Thanks for your contribution!
No description provided.