Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HTTP fragmentation #3540

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Conversation

vladpaiu
Copy link
Member

Summary
Sometimes, HTTP POST traffic can become fragmented, and the HTTP module does not support it.

Details
Enforce fragmentation at the interface layer somehow, and notice how fragmentation breaks httpd mod.

Solution
Accumulate HTTP incoming buffer until complete, and only then pass it to the processing layer.

Compatibility
Backwards compatible

@vladpaiu vladpaiu added the bug label Dec 12, 2024
@vladpaiu vladpaiu added this to the 3.6-dev milestone Dec 12, 2024
modules/httpd/httpd_proc.c Outdated Show resolved Hide resolved
modules/httpd/httpd_proc.c Outdated Show resolved Hide resolved
@bogdan-iancu bogdan-iancu self-assigned this Dec 12, 2024
@bogdan-iancu bogdan-iancu merged commit 9e63d59 into OpenSIPS:master Dec 13, 2024
51 checks passed
@bogdan-iancu
Copy link
Member

Thank you @vladpaiu ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants