Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settable MAXIMUM_MODEL_AGE #442

Open
Flix6x opened this issue Feb 13, 2023 · 5 comments
Open

Settable MAXIMUM_MODEL_AGE #442

Flix6x opened this issue Feb 13, 2023 · 5 comments
Labels
good first issue Good for newcomers

Comments

@Flix6x
Copy link

Flix6x commented Feb 13, 2023

The MAXIMUM_MODEL_AGE is hardcoded to 7 days (in pipeline/train_model.py). While I consider this a reasonable default, I would find it useful to be able to override the default by setting a different age explicitly, to support assets that require more frequent or less frequent retraining.

Could this be done, for example, by introducing it as a variable in the function signature of train_model_pipeline()? Or perhaps you'd consider it more suitable as a PredictionJobDataClass attribute?

@FrankKr FrankKr added the good first issue Good for newcomers label Mar 2, 2023
@FrankKr
Copy link
Collaborator

FrankKr commented Mar 2, 2023

Good idea, thanks for suggesting! I have added the label 'good first issue' to it.

@TheoPascoli
Copy link

Hello, is this issue still pending, resolved, or is it no longer needed?

@Flix6x
Copy link
Author

Flix6x commented Nov 2, 2023

From my end, still pending. I could work on it, provided I get some input on the desired implementation approach (see my previous question).

@TheoPascoli
Copy link

I was asking because I wanted to do it myself. I don't necessarily need this development to be done, but since it is labeled as a 'good first issue,' I thought it would be a good entry point to the repository for me, especially if there are other developments to be done later on from the RTE side. I'll try something then

@JonitaRuiter
Copy link
Collaborator

Hi Theo, sorry for the late reply! I think this issue is still pending, so if you can propose a PR, I'll make sure it is reviewed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants