Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenID depedency migration failures with Authentication with newest *node* #1021

Closed
Martii opened this issue Jun 21, 2016 · 2 comments
Closed

OpenID depedency migration failures with Authentication with newest *node* #1021

Martii opened this issue Jun 21, 2016 · 2 comments
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. migration Use this to indicate that it may apply to an existing or announced migration.

Comments

@Martii
Copy link
Member

Martii commented Jun 21, 2016 •
edited
Loading

So post production maintenance yielded unexpected and probable failures in passport-yahoo and passport-aol when flipping to node@6.x

Possible solutions:

EDIT: We have ~3 months left on the node@4.x line before node@6.x goes into LTS (then another 6 months until maintenance) e.g. we should deal with this very soon. passport-steam worked with my account albeit their server threw an error the first time but with a retry it was fine so it was probably a hiccup... and this dep is by a different author/maintainer.

schedule
@Martii Martii added sooner Sooner would be appreciated. migration Use this to indicate that it may apply to an existing or announced migration. labels Jun 21, 2016
@Martii Martii mentioned this issue Sep 26, 2016
Closed
Martii pushed a commit to OpenUserJS/passport-openid that referenced this issue Oct 31, 2016
Renamed branch to mnzt's damaged fork implementation used in *passpor…
2928996 
…t-steam*

* Should reduce the dep tree size

Applies to OpenUserJS/OpenUserJS.org#1021
@Martii Martii self-assigned this Oct 31, 2016
Martii pushed a commit to OpenUserJS/passport-openid that referenced this issue Oct 31, 2016
Rename to match mznt's implementation used in *passport-steam*
56703c2 
* Should reduce the overall size of depth 1 dependencies and potential npm collisions

**NOTE**
Cherry picked as that repo is severely damaged.

Applies to OpenUserJS/OpenUserJS.org#1021
Martii pushed a commit to OpenUserJS/passport-aol that referenced this issue Oct 31, 2016
Bubble up the OpenID2 dep to this fork
e22681e 
* Automatic editor white-space cleanup and verified

Applies to OpenUserJS/OpenUserJS.org#1021
Martii pushed a commit to OpenUserJS/passport-yahoo that referenced this issue Oct 31, 2016
Bubble up the OpenID2 dep to this fork
5ffd7b3 
* Automatic editor white-space cleanup and verified

Applies to OpenUserJS/OpenUserJS.org#1021
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Oct 31, 2016
Scoot to our forks for the remainder of OpenID passports
3497477 
* AOL tested and passes... awaiting Yahoo verification

Applies to OpenUserJS#1021 and presumably OpenUserJS#1031
@Martii Martii mentioned this issue Oct 31, 2016
Merged
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Nov 1, 2016
Some dep updates
99e6033 
* Please read their CHANGELOGs
* Fix dead links for *octicons* ... author name change detected for redirect. See below notes.
* Bump project requirements to latest LTS
* *bundler* gem update
* Add README.md refs for OpenUserJS#1021 and OpenUserJS#1031
* Delete op retested

**NOTES**
*octicons* has gone svg and no longer a font type in the next major rev... Awaiting further detailed analysis before dep update. Related to OpenUserJS#186
@Martii Martii mentioned this issue Nov 1, 2016
Merged
@Martii
Copy link
Member Author

Martii commented Nov 1, 2016

Closing from a49abdd

@Martii Martii closed this as completed Nov 1, 2016
@Martii Martii removed their assignment Nov 1, 2016
@Martii Martii added CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. and removed sooner Sooner would be appreciated. labels Nov 1, 2016
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Nov 2, 2016
Repair *passport-steam*
23e225f 
* Way back in https://github.com/liamcurry/passport-steam/blob/765869b566319bf7e5c44a4d3e1d4b6439731383/README.md the callback signature was modified to include a profile. The "hijacking" didn't account for this.
* Prevents a server trip

Applies to OpenUserJS#1021 (comment)
@Martii Martii mentioned this issue Nov 2, 2016
Merged
@Martii
Copy link
Member Author

Martii commented Nov 3, 2016

Refs:

Martii pushed a commit to OpenUserJS/passport-steam that referenced this issue Aug 27, 2017
Bubble up the OpenID2 dep to this fork
d9198e3 
*NOTE(S)*
* Testing this fix for permanence in contrast to alternate fix of `"passport-openid": "^0.4.0",` in liamcurry@4d19567

Applies to OpenUserJS/OpenUserJS.org#1021
@OpenUserJS OpenUserJS locked as resolved and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. migration Use this to indicate that it may apply to an existing or announced migration.
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Martii