Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security handling with sequenced frames #1015

Open
tobiasgraf opened this issue Oct 25, 2016 · 4 comments
Open

Security handling with sequenced frames #1015

tobiasgraf opened this issue Oct 25, 2016 · 4 comments
Assignees

Comments

@tobiasgraf
Copy link
Contributor

The ZWave.Me Wall Controller Wall C-S sometimes sends its frames sequenced when holding down a button.
In ZWSecurity.cpp:350 there is a todo

        /* XXX TODO: Check the Sequence Header Frame to see if this is the first part of a
         * message, or 2nd part, or a entire message.
         *
         * I havn't actually seen a Z-Wave Message thats too big to fit in a encrypted message
         * yet, so we will look at this if such a message actually exists!
         */

describing exactly this behavior.
See the attached file for some logs.

sequenced_security_frame.txt

@Fishwaldo
Copy link
Member

Thanks. As the comment says, I'd never seen this before. I'll look into it soon.

@aromanro
Copy link

aromanro commented Apr 6, 2018

I can confirm that there are devices that send sequenced security frames. One example is 'Senzor 4 in 1 Zipato (Philio)'.

@Fishwaldo
Copy link
Member

Can you provide a log extract of the sequenced frames?

@aromanro
Copy link

I didn't use open zwave for noticing that, but code I wrote. I'm not sure I can provide a log from it, I signed an NDA and I'm not sure if that doesn't qualify as disclosure. Anyway, solving this wasn't hard at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants