Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Erc20Wrapper extension #498

Draft
wants to merge 68 commits into
base: main
Choose a base branch
from
Draft

feat: Erc20Wrapper extension #498

wants to merge 68 commits into from

Conversation

Ifechukwudaniel
Copy link
Contributor

@Ifechukwudaniel Ifechukwudaniel commented Jan 16, 2025 •
edited
Loading

Resolves #354

PR Checklist

  • Tests
  • Documentation
  • Changelog

@netlify Netlify
Copy link

netlify bot commented Jan 16, 2025 •
edited
Loading

✅ Deploy Preview for contracts-stylus canceled.

Name Link
🔨 Latest commit b34ebfd
🔍 Latest deploy log https://app.netlify.com/sites/contracts-stylus/deploys/67cee74a96152d0008785162

@codecov Codecov
Copy link

codecov bot commented Jan 16, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 59.09091% with 63 lines in your changes missing coverage. Please review.

Project coverage is 87.7%. Comparing base (97fd57b) to head (b34ebfd).

Files with missing lines Patch % Lines
contracts/src/token/erc20/extensions/wrapper.rs 59.0% 63 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
contracts/src/token/erc20/extensions/wrapper.rs 59.0% <59.0%> (ø)
🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Ifechukwudaniel Ifechukwudaniel marked this pull request as draft January 16, 2025 01:36
@Ifechukwudaniel Ifechukwudaniel changed the title Erc20 wrapper [FEATURE] Erc20Wrapper Jan 24, 2025
@bidzyyys bidzyyys changed the title [FEATURE] Erc20Wrapper feat: Erc20Wrapper extension Jan 27, 2025
bidzyyys
bidzyyys reviewed Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progess @Ifechukwudaniel, please focus on now:

  • Increasing E2E test coverage
  • Improving Rust docs
  • Solving all clippy warnings.

examples/erc20-wrapper/tests/erc20wrapper.rs Outdated
// ============================================================================

#[e2e::test]
async fn constructs(alice: Account) -> Result<()> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increase E2E test coverage.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On this

@Ifechukwudaniel
Copy link
Contributor Author

Ifechukwudaniel commented Feb 5, 2025 •
edited
Loading

I have been kind of on another project, but I will do my best to round this up asap

@bidzyyys
Copy link
Collaborator

Hey @Ifechukwudaniel! Are you going to solve the failing CI jobs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidzyyys bidzyyys bidzyyys left review comments

@qalisander qalisander Awaiting requested review from qalisander qalisander is a code owner

@0xNeshi 0xNeshi Awaiting requested review from 0xNeshi 0xNeshi is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: ERC20Wrapper extension
2 participants
@Ifechukwudaniel @bidzyyys