Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout after tool_opencast | apitimeout_1 ist not reported as timeout #56

Closed
BerengarWLehr opened this issue Sep 13, 2023 · 3 comments · Fixed by #70
Closed

Timeout after tool_opencast | apitimeout_1 ist not reported as timeout #56

BerengarWLehr opened this issue Sep 13, 2023 · 3 comments · Fixed by #70
Assignees
@ferishili
Labels
bug Something isn't working

Comments

@BerengarWLehr
Copy link

If an timeout occurs after config option tool_opencast | apitimeout_1 milliseconds the reported error connection_failure is not specific enough. Should be e.g. "Timeout after x seconds".
@NinaHerrmann
Copy link
Contributor

Hey @BerengarWLehr I aggre, can you provide a pull request? :)

@ferishili ferishili added the bug Something isn't working label Sep 26, 2023
@ferishili
Copy link
Contributor

Hi,
this problem appears to be important, therefore I labeled it as bug, in order for us to take care of it in the next release!

@bluetom bluetom added the 4.5.1 label Nov 10, 2024
@bluetom bluetom removed the 4.5.1 label Nov 22, 2024
@ferishili ferishili self-assigned this Dec 11, 2024
@ferishili
Copy link
Contributor

ferishili commented Dec 11, 2024 •
edited
Loading

After a closer look, I have come to this decision:
The class opencast_connection_exception in block_opencast should not be responsible for handling Opencast server errors or exceptions. The correct place for managing such exceptions is within this plugin.

ferishili added a commit to ferishili/moodle-tool_opencast that referenced this issue Dec 16, 2024
@ferishili
improved opencast api exceptions and handlers,
bfa2f3b 
This PR fixes Opencast-Moodle#56
@ferishili ferishili mentioned this issue Dec 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferishili ferishili

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improved Opencast API exceptions and error handling ferishili/moodle-tool_opencast
4 participants
@NinaHerrmann @bluetom @ferishili @BerengarWLehr