Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events & Blog tags direct to wrong page #62

Open
jules32 opened this issue Oct 11, 2023 · 4 comments
Open

Events & Blog tags direct to wrong page #62

jules32 opened this issue Oct 11, 2023 · 4 comments
Assignees

Comments

@jules32
Copy link
Contributor

jules32 commented Oct 11, 2023

@samanthacsik when you get a chance, would you be able to double-check how the clickable tags at the top of specific blogs/events work for Events and Blog categories?

If I click on "Events" or "workshops" tags from this link:
https://openscapes.org/events/2022-09-13-tidepool-digital/index.html

image

I'm taken to the main Connect page

image.

Compare to clicking on the right nav-bar for "workshops", which does go to the correct place:

image

This might be something with Netlify? I can help dig into that if that is the case. Thank you!

@samanthacsik
Copy link
Collaborator

Hi @jules32! I was poking around a bit and realized that clicking a category at the top of an Event (regardless of the tag) directed us back to the "Upcoming Events" listing on the Connect with Us page and filtered any Events that appeared in that listing by that category (rather than sending us the actual Events listing page and filtering all Events posts). It was more obvious when I chose a category like MENTORSHIP:

Screen Shot 2023-10-11 at 2 58 43 PM

which directed me to the Connect with Us page and the filtered the Upcoming Events listing for just the post(s) tagged with MENTORSHIP (there happened to be only one):

Screen Shot 2023-10-11 at 2 58 35 PM

I checked out the YAMLs of both blog.qmd and events.qmd and noticed that categories was set to true in the blog listing, but set to numbered in the events listing. I'm not totally sure why they were different (and tbh, I don't know what setting categories: numbered actually does). But updating the it to categories: true in the YAML of events.qmd seemed to fix things!

Going to open a PR now :)

@jules32
Copy link
Contributor Author

jules32 commented Oct 11, 2023

Ah, thanks Sam! So that also explains also why you're taken to the home page (openscapes.org) when you click on a blog tag, since the blog listing page is embedded in the home page. Would there be a way for it to take you to

https://openscapes.org/blog.html#category=how-we-work

rather than

https://openscapes.org/index.html#category=how-we-work?

...And would we want that? It might be more where people would expect to end up

samanthacsik added a commit that referenced this issue Oct 12, 2023
this seems to solve the issue of redirecting users to the index blog listing when a category is clicked on, rather than the actual blog listing page, filtered for that category. See issue #62 for more details: #62
@samanthacsik
Copy link
Collaborator

Oh great catch, I didn't realize it was happening on the blog as well! Okay after a bit of fiddling, I ended up removing the following two lines from the blog.qmd YAML:

sort-ui: false
filter-ui: false

Neither of these options were included in the events.qmd YAML.

Both options are true by default, and I think I may have copied them over from my own website's listing page without thinking much about what they do. I think settingfilter-ui to false may have something to do with the behavior we're seeing (i.e. being brought to the "mini" listing rather than the filtered full listing page), but I'm not totally sure. Regardless, I don't really see a need to set either of them to false on blog.qmd, and removing those options seems to fix the issue.

@jules32
Copy link
Contributor Author

jules32 commented Nov 17, 2023

We fixed the issue with Blog! woo! 71051ec

Still not with Events though, here is a PR where we were working and testing, then closed when didn't fix. Netlify deploy links still live there: #73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants