Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Auto cropping for Progressive Scan with Screen Offsets enabled #12051

Open
flavionm opened this issue Nov 30, 2024 · 0 comments
Labels
Enhancement / Feature Request FR: Awaiting Consideration The feature request is awaiting a team members consideration.

Comments

@flavionm
Copy link

Description

The Screen Offsets setting is currently required for some games. For example in God of War 1, cutscenes in Progressive Mode display a black bar at the bottom without it. However, the setting also boxes the image in Progressive Scan mode, regardless of the game. In Interlace mode it also allows things like in game screen position adjustments, but it fills the whole screen.

Currently I'm not using Integer Scaling because I want to fill the screen vertically while maintaining the correct aspect ratio (well, the aspect ratio it would have on an old CRT TV, to be more precise), currently my only option is to leave the setting disabled by default and only enable it for games that require it, while using the Crop option to fill the screen for those games.

Reason

Having to fiddle with game specific settings just to achieve a standardized look for all games played, especially when that look is basically how it would look originally, is not ideal. Not that having the option is bad, but the defaults at least should aim to be as accurate as possible.

Not to mention a lot of times you don't actually know whether a game needs it or not. For some it is obvious there is something wrong, like in God of War 1's case, but if it's a subtler effect you won't notice isn't there if you don't expect it, you'll likely miss out on it completely. If anything, the Screen Offsets option should be on by default, and if it's drawbacks aren't apparent, it could be.

Examples

God of War 1, 4:3 Aspect Ratio, Progressive Scan, Screen Offsets on:

Image

God of War 1, 4:3 Aspect Ratio, Progressive Scan, Screen Offsets on:

Image

While the screenshot is from the internal resolution, when maximizing to full screen the the same margins will be around the picture, and switching the setting will increase or decrease the actual image size.

God of War 1, 4:3 Aspect Ratio, Interlaced, Screen Offsets on:

Image

God of War 1, 4:3 Aspect Ratio, Interlaced, Screen Offsets off:

Image

Here both images actually have different resolutions, but both look practically the same when maximized. With Screen Offsets on it actually has a 1.33333 ratio, while with it off it's a bit off, being at 1.33258.

@flavionm flavionm added Enhancement / Feature Request FR: Awaiting Consideration The feature request is awaiting a team members consideration. labels Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement / Feature Request FR: Awaiting Consideration The feature request is awaiting a team members consideration.
Projects
None yet
Development

No branches or pull requests

1 participant