You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When we create a stable release, we tag it with the stable release number. There's a chance the same commit is also tagged with an unstable release number. It appears our scripts end up including both numbers in the filename when creating an app bundle, separated by a newline.
Download the macOS release of PCSX2 stable v2.2.0 (doesn't need to be done on macOS)
Untar it
Look at the name of the .app bundle
It's named PCSX2-v2.1.236\nv2.2.0.app
Edit: I manually replaced the release asset so you can't reproduce this anymore. It will happen again if we do the same process for the next stable PCSX2 release.
Expected Behavior
It should be named PCSX2-v2.2.0.app
PCSX2 Revision
v2.2.0
Operating System
macOS (or any with the ability to untar a .tar.xz, if you're just checking)
The text was updated successfully, but these errors were encountered:
Describe the Bug
When we create a stable release, we tag it with the stable release number. There's a chance the same commit is also tagged with an unstable release number. It appears our scripts end up including both numbers in the filename when creating an app bundle, separated by a newline.
(We currently use
git tag --points-at HEAD
to get the tag. I wonder if there's something supplied by GitHub Actions we could use instead, as from Git there's not really any way to know which tag is the "correct" one...)Reproduction Steps
.app
bundlePCSX2-v2.1.236\nv2.2.0.app
Edit: I manually replaced the release asset so you can't reproduce this anymore. It will happen again if we do the same process for the next stable PCSX2 release.
Expected Behavior
It should be named
PCSX2-v2.2.0.app
PCSX2 Revision
v2.2.0
Operating System
macOS (or any with the ability to untar a
.tar.xz
, if you're just checking)The text was updated successfully, but these errors were encountered: