Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: macOS Stable Releases are named incorrectly #12184

Open
TellowKrinkle opened this issue Jan 12, 2025 · 0 comments
Open

[BUG]: macOS Stable Releases are named incorrectly #12184

TellowKrinkle opened this issue Jan 12, 2025 · 0 comments

Comments

@TellowKrinkle
Copy link
Member

TellowKrinkle commented Jan 12, 2025

Describe the Bug

When we create a stable release, we tag it with the stable release number. There's a chance the same commit is also tagged with an unstable release number. It appears our scripts end up including both numbers in the filename when creating an app bundle, separated by a newline.

(We currently use git tag --points-at HEAD to get the tag. I wonder if there's something supplied by GitHub Actions we could use instead, as from Git there's not really any way to know which tag is the "correct" one...)

Reproduction Steps

  • Download the macOS release of PCSX2 stable v2.2.0 (doesn't need to be done on macOS)
  • Untar it
  • Look at the name of the .app bundle
  • It's named PCSX2-v2.1.236\nv2.2.0.app

Edit: I manually replaced the release asset so you can't reproduce this anymore. It will happen again if we do the same process for the next stable PCSX2 release.

Expected Behavior

It should be named PCSX2-v2.2.0.app

PCSX2 Revision

v2.2.0

Operating System

macOS (or any with the ability to untar a .tar.xz, if you're just checking)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants