Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Changing game title metadata is broken #12217

Open
13xforever opened this issue Jan 19, 2025 · 1 comment
Open

[BUG]: Changing game title metadata is broken #12217

13xforever opened this issue Jan 19, 2025 · 1 comment
Labels

Comments

@13xforever
Copy link

13xforever commented Jan 19, 2025

Describe the Bug

When changing the Title metadata for the game, the change is automatically reverted on Enter.
Also, the Restore button becomes enabled, even though the change was already reverted automatically.
Also, the game is moved to the bottom of the library (but not always the very bottom) list regardless of the actual title value until library re-scan/application restart.
Also, there's no way to set Sorting Title metadata unless it was already provided by redump metadata and set automatically.

Reproduction Steps

Right-click on any game, select Properties, change Title in the Summary tab, hit Enter to apply.

Expected Behavior

Custom metadata value is applied on Enter/closing the Properties dialog and is not reset on game library re-scan/application restart (this is probably shared with Duckstation).
Also, there's a way to set the sorting title value for any game regardless of available built-in information.

PCSX2 Revision

v2.3.119

Operating System

Windows 11

If Linux - Specify Distro

No response

Logs & Dumps

Changing the title two times: 1) committing with Enter, 2) closing the dialog: emulog.zip

@13xforever 13xforever added the Bug label Jan 19, 2025
@13xforever
Copy link
Author

13xforever commented Jan 20, 2025

I did some digging, and the problem seems to stem from improper file path escaping in inis\custom_properties.ini if the path contains [ and/or ] characters, which produces malformed ini file with truncated paths, so the properties never match the full path.

Also, as a result, changing the title multiple times results in multiple duplicate values stored under malformed sections in the ini file.

Example:

[E:\FakeCDs\PS2 Games\Ace Combat 04 - Shattered Skies [SLUS20152]
Title = Ace Combat 04: Shattered Skies
Title = Ace Combat 04: Shattered Skies
Title = Ace Combat 04: Shattered Skies


[E:\FakeCDs\PS2 Games\Ace Combat 5 - The Unsung War [SLUS20851]
Title = Ace Combat 5: The Unsung War


[E:\FakeCDs\PS2 Games\Ace Combat Zero - The Belkan War [SLUS21346]
Title = Ace Combat Zero: The Belkan War


[E:\FakeCDs\PS2 Games\Ar tonelico - Melody of Elemia [SLES54586]
Title = Ar tonelico: Melody of Elemia
Title = Ar tonelico: Melody of Elemia
Title = Ar tonelico: Melody of Elemia


[E:\FakeCDs\PS2 Games\Ar Tonelico - Melody of Elemia [SLUS21445]
Title = Ar tonelico: Melody of Elemia (undub)
Title = Ar tonelico: Melody of Elemia
Title = Ar tonelico - Melody of Elemia (undub)


[E:\FakeCDs\PS2 Games\Ar tonelico II - Melody of Metafalica [SLES55444]
Title = Ar tonelico II: Melody of Metafalica


[E:\FakeCDs\PS2 Games\.hack//Infection [SLES52237]
Title = .hack//Infection


[E:\FakeCDs\PS2 Games\Ace Combat 04 - Shattered Skies [SLUS20152].iso]
Title = Ace Combat 04: Shattered Skies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant