Skip to content

Commit

Permalink
Merge pull request #18 from runette/remove-pipelinexecutir
Browse files Browse the repository at this point in the history
Remove Pipeline Executor
  • Loading branch information
runette authored Feb 6, 2023
2 parents f846f9e + 31aad74 commit 71254eb
Show file tree
Hide file tree
Showing 12 changed files with 313 additions and 183 deletions.
19 changes: 19 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,22 @@
# Version 2.2.0

This is a major change to the underlying code to remove the deprecated `pdal::PipelineExecutor` and replace it with `pdal::PipelineManager`.

This version also introduces the following non-breaking changes to the ABI:

- Addition of the following method to allow the consuming app to tell if a pipeline is streamable:

```
bool PDALPipelineIsStreamable(PDALPipelinePtr pipeline)
```

- Addition of the following method to allow the consuming application to run a pipeline in streaming mode. If the pipeline is non-streamable it will be silently run in standard mode:

```
bool PDALExecutePipelineAsStream(PDALPipelinePtr pipeline)
```


# Version 2.1.1

Changes to allow compilation with PDAL 2.4.0
Expand Down
3 changes: 3 additions & 0 deletions source/pdal/pdalc_config.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
* POSSIBILITY OF SUCH DAMAGE.
*****************************************************************************/

#define _CRT_SECURE_NO_WARNINGS
#include "pdalc_config.h"

#include <cstdlib>
Expand All @@ -36,6 +37,8 @@
#include <pdal/pdal_config.hpp>
#include <pdal/util/Utils.hpp>



namespace pdal
{
namespace capi
Expand Down
1 change: 1 addition & 0 deletions source/pdal/pdalc_config.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@

#include "pdalc_forward.h"


/**
* @file pdalc_config.h
* Functions to retrieve PDAL version and configuration information.
Expand Down
4 changes: 3 additions & 1 deletion source/pdal/pdalc_dimtype.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,13 @@
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
* POSSIBILITY OF SUCH DAMAGE.
*****************************************************************************/

#define _CRT_SECURE_NO_WARNINGS
#include "pdal/pdalc_dimtype.h"

#include <pdal/DimType.hpp>



namespace pdal
{
namespace capi
Expand Down
4 changes: 2 additions & 2 deletions source/pdal/pdalc_forward.h
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
namespace pdal
{
struct DimType;
class PipelineExecutor;
class PipelineManager;
class PointView;
class TriangularMesh;

Expand All @@ -64,10 +64,10 @@ using MeshPtr = std::shared_ptr<TriangularMesh>;
namespace capi
{
class PointViewIterator;
using Pipeline = std::unique_ptr<pdal::PipelineExecutor>;
using PointView = pdal::PointViewPtr;
using TriangularMesh = pdal::MeshPtr;
using DimTypeList = std::unique_ptr<pdal::DimTypeList>;

}
}

Expand Down
Loading

0 comments on commit 71254eb

Please sign in to comment.