Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create square, cube, disk, and sphere functions in tools since scikit-image is deprecating them #1006

Open
mkaguer opened this issue Jan 14, 2025 · 1 comment
Assignees
Labels
maint PR tag for maintenance related changes

Comments

@mkaguer
Copy link
Contributor

mkaguer commented Jan 14, 2025

Let's use our own porespy structuring elements to avoid deprecation issue in the future and to avoid using long winded name.

Everywhere we do from skimage.morphology import square, cube needs to be replaced with porespy's

@jgostick jgostick added the maint PR tag for maintenance related changes label Jan 14, 2025
@jgostick jgostick moved this to Backlog in PoreSpy V3.0 Jan 15, 2025
@jgostick jgostick changed the title Scikit-image deprecating square for footprint_rectangle Create square, cube, disk, and sphere functions in tools since scikit-image is deprecating them Jan 15, 2025
@jgostick jgostick moved this from Backlog to API in PoreSpy V3.0 Jan 15, 2025
@jgostick jgostick moved this from API to Enhancements and Maintenance in PoreSpy V3.0 Mar 25, 2025
@jgostick
Copy link
Member

Issue #1057 is also relevant here. Those functions could be added to the same place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maint PR tag for maintenance related changes
Projects
Status: Enhancements and Maintenance
Development

No branches or pull requests

2 participants