From 578a5ca7f039155ec35feb413135b8c80f4a56f2 Mon Sep 17 00:00:00 2001 From: Maximilian Roos <5635139+max-sixty@users.noreply.github.com> Date: Wed, 23 Aug 2023 00:32:24 -0700 Subject: [PATCH] ci: Fix job skips (#3378) --- .github/workflows/tests.yaml | 26 +++++++++++++++++++++++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml index 53e0cf79505f..43530404f69f 100644 --- a/.github/workflows/tests.yaml +++ b/.github/workflows/tests.yaml @@ -478,9 +478,29 @@ jobs: # We're currently including `nightly` because I'm not sure whether # it's always reliable; e.g. `cargo-audit` allowed-failures: check-links-markdown, nightly - # Easier than writing out every job — and it's our own rules deciding - # whether jobs are skipped or not. - allowed-skips: ${{ toJSON(needs) }} + # We skip jobs deliberately, so we are OK if any are skipped. + # + # Copy-pasted from `needs`, since it needs to be a json list, so `${{ + # toJSON(needs) }}` (which is a map) doesn't work. + # https://github.com/re-actors/alls-green/issues/23 + allowed-skips: | + [ + "build-web", + "check-links-book", + "check-links-markdown", + "lint-megalinter", + "nightly", + "publish-web", + "test-dotnet", + "test-elixir", + "test-java", + "test-js", + "test-lib", + "test-php", + "test-python", + "test-rust", + "test-rust-main" + ] build-prqlc: runs-on: ${{ matrix.os }}