Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix job skips #3378

Merged
merged 2 commits into from
Aug 23, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -478,9 +478,29 @@ jobs:
# We're currently including `nightly` because I'm not sure whether
# it's always reliable; e.g. `cargo-audit`
allowed-failures: check-links-markdown, nightly
# Easier than writing out every job — and it's our own rules deciding
# whether jobs are skipped or not.
allowed-skips: ${{ toJSON(needs) }}
# We skip jobs deliberately, so we are OK if any are skipped.
#
# Copy-pasted from `needs`, since it needs to be a json list, so `${{
# toJSON(needs) }}` (which is a map) doesn't work.
# https://github.com/re-actors/alls-green/issues/23
allowed-skips: |
[

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, you don't have to wrap this as a JSON list, a comma-separated list works too:
https://github.com/python/cpython/blob/809ea7c/.github/workflows/build.yml#L550-L577

"build-web",
"check-links-book",
"check-links-markdown",
"lint-megalinter",
"nightly",
"publish-web",
"test-dotnet",
"test-elixir",
"test-java",
"test-js",
"test-lib",
"test-php",
"test-python",
"test-rust",
"test-rust-main"
]

build-prqlc:
runs-on: ${{ matrix.os }}
Expand Down