New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to sprs v0.8 and sprs-ldl v0.6 to enable more tests #1

Merged

PTNobel merged 1 commit into PTNobel:master from vbarrielle:update_sprs

Aug 5, 2020

Contributor

vbarrielle commented Aug 5, 2020

I've recently updated sprs to be able to test the performance issue more (see sparsemat/sprs#199).

With the latest version, it's now easy to disable symmetry check, use Cuthill-McKee ordering or use the original C implementation of LDL.

Results:

original: 5000ms
Cuthill-McKee: 4313ms
LDL C implementation (Cuthill-McKee): 3383ms
LDL C implementation (no permutation): 4036ms

Clearly the comparison with the C code shows there is some inefficiency in my implementation, which I will now investigate.


          Update to sprs v0.8 and sprs-ldl v0.6 to enable more tests

af72f22

Owner

PTNobel commented Aug 5, 2020

Thank you! Sorry about vanishing the last few weeks. I've had some stuff come up.

PTNobel merged commit f7c4fc8 into PTNobel:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet