Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create reusable utility for agenda folder validation #3217

Open
coderabbitai bot opened this issue Feb 15, 2025 · 7 comments
Open

Create reusable utility for agenda folder validation #3217

coderabbitai bot opened this issue Feb 15, 2025 · 7 comments

Comments

@coderabbitai
Copy link

coderabbitai bot commented Feb 15, 2025

Background

Currently, agenda folder validation logic is duplicated across different mutations. This includes checking if:

  • The folder exists
  • The folder belongs to the correct event
  • The folder is compatible with agenda items

Proposal

Create a reusable utility function to centralize this validation logic, making the code more maintainable and reducing duplication.

References

Notes

/cc @shivasankaran18

@github-actions github-actions bot added the unapproved Unapproved for Pull Request label Feb 15, 2025
@palisadoes
Copy link
Contributor

This issue is available for assignment

@bandhan-majumder
Copy link

bandhan-majumder commented Feb 15, 2025

@palisadoes please assign this issue to me as I will also work with the same in frontend later on in a feature request

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Feb 26, 2025
@Cioppolo14
Copy link
Contributor

Unassigning due to inactivity and/or no submitted PR. Others need to get a chance. Please let us know whether you want to be reassigned before someone else requests assignment or select another issue.

@bandhan-majumder
Copy link

@Cioppolo14 please reassign.

@palisadoes palisadoes removed the unapproved Unapproved for Pull Request label Feb 26, 2025
@bandhan-majumder
Copy link

bandhan-majumder commented Feb 26, 2025

This issue will need to create another common mutation function with defining the type of drizzle client only with the schema it interacts overall with all the mutations that presently has this logic. As they get the drizzle client from the context, their type is predefined.
@xoldd can you please confirm this issue once. Should I create a common one or they are better being independent.

@meetulr
Copy link
Contributor

meetulr commented Mar 4, 2025

unassigning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants