Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoMongo: migrate the file test/routes/graphql/Mutation/deleteChatMessage.test.ts to integration test #3273

Open
Piyushk8 opened this issue Feb 22, 2025 · 9 comments
Assignees
Labels
bug Something isn't working GSoC Priority security Security fix test Testing application

Comments

@Piyushk8
Copy link

Describe the bug

The deleteChatMessage GraphQL mutation (in test/routes/graphql/Mutation/deleteChatMessage.test.ts) uses mocked tests, contradicting the project's requirement for integration testing via real API calls for all mutations in that directory.

Expected Behavior

All GraphQL mutations, including deleteChatMessage, should be thoroughly integration tested using actual API calls. Mutation files should reside in test/routes/Graphql/Mutation/*.

Actual Behavior

deleteChatMessage uses mocked tests, bypassing the real API and services.

Impact

Mocked tests provide a false sense of security, risking undetected bugs and regressions. Inconsistent testing hinders maintainability.

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@Piyushk8 Piyushk8 added the bug Something isn't working label Feb 22, 2025
@github-actions github-actions bot added security Security fix test Testing application unapproved Unapproved for Pull Request labels Feb 22, 2025
@abbi4code
Copy link

can i work on this @palisadoes

@palisadoes palisadoes added GSoC Priority and removed unapproved Unapproved for Pull Request labels Feb 24, 2025
@abbi4code
Copy link

@bandhan-majumder Do you want to work on this issue? I am already working on a different issue, and I don’t want to be a hurdle in between, as this is a GSoC priority issue.

@abbi4code
Copy link

You can also ask @palisadoes to get it assigned to yourself.

@dimpalmang20
Copy link

I can work on this issue

@palisadoes palisadoes assigned dimpalmang20 and unassigned abbi4code Mar 1, 2025
@bandhan-majumder
Copy link

Thanks @abbi4code . I will ask to take this up if it gets no activity with in 10 days.

@palisadoes
Copy link
Contributor

How's progress on this? It needs to be completed as a GSoC prerequisite.

@Piyushk8
Copy link
Author

Piyushk8 commented Mar 9, 2025

I have created a PR related to this (update message), so if any help is needed, I'll be happy to help !

@dimpalmang20
Copy link

dimpalmang20 commented Mar 9, 2025 via email

@palisadoes
Copy link
Contributor

This is for the develop-postgres branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GSoC Priority security Security fix test Testing application
Projects
Status: Backlog
Status: Backlog
Development

No branches or pull requests

5 participants