Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoMongo: Apply rate limiting to API endpoints #3309

Open
im-vedant opened this issue Feb 27, 2025 · 19 comments
Open

NoMongo: Apply rate limiting to API endpoints #3309

im-vedant opened this issue Feb 27, 2025 · 19 comments
Assignees
Labels
bug Something isn't working feature request security Security fix test Testing application

Comments

@im-vedant
Copy link

Overview
We created a hosted Test Website for us to evaluate the application's develop-postgres branch.
The implementation of this site exposed many shortcomings which are documented in our Talawa Security Improvements - 2025 document.
This is one of the action plan issues in that document.

This issue requires someone with very good knowledge of the code base
This includes:

  1. Many merged PRs
  2. Meaningful updates to the repository
  3. Active participation in our slack channels and design document creation

Describe the bug

Currently, Talawa API does not have API rate limiting.

Expected behavior

  1. The design must comply with the Talawa Security Improvements document
    https://docs.google.com/document/d/16fJEZQHzji_RuarBn-33UvFYUh78ERZPKRFyTnvxyxc/edit?tab=t.0

Additional details

You will need to submit multiple PRs to get this done:

  1. This will reduce the risk of merge conflicts
  2. It will make reviews faster
@im-vedant
Copy link
Author

@palisadoes assign

@github-actions github-actions bot added bug Something isn't working security Security fix test Testing application unapproved Unapproved for Pull Request labels Feb 27, 2025
@Cioppolo14
Copy link
Contributor

Our policy is to assign no more than two issues to each contributor across all repositories. This way everyone gets a chance to participate in the projects. We sometimes give exceptions for more urgent cases and sometimes we lose track, but the policy stands. You have reached your limit, please wait until your existing issues are closed before requesting more issues. You could unassign yourself from one of the other issues too. @im-vedant

@prayanshchh
Copy link
Contributor

prayanshchh commented Feb 27, 2025

would like to work on this one, I have asked to unassign from two issues assigned to me

  1. Error when clicking on Manage button in talawa-admin as Admin in develop branch talawa-admin#3598
  2. NoMongo: Several Post Bugs #2839

@Cioppolo14

@palisadoes palisadoes removed the unapproved Unapproved for Pull Request label Feb 27, 2025
@VanshikaSabharwal
Copy link

Please Assign

@iamanishx
Copy link

@im-vedant what are the approaches to implement the web-server rate limiting ?

@iamanishx
Copy link

@im-vedant i have got that but are you applying in talawa-api?
Using fastify rate limit ?

@im-vedant
Copy link
Author

@iamanishx Yes, I am applying rate limiting to talawa api. I am not using fast rate limit.

@iamanishx
Copy link

@iamanishx Yes, I am applying rate limiting to talawa api. I am not using fast rate limit.

@im-vedant Can you confirm what you have planned to use .
This thing can be implemented in the BFF server which will be more better!

@palisadoes
Copy link
Contributor

@im-vedant What is your proposed approach?

@palisadoes
Copy link
Contributor

palisadoes commented Mar 1, 2025

I just saw the document.

@iamanishx

  1. What is the BFF approach?
  2. I remember seeing the document. Please post the link here.
  3. Is there an issue related to it? We'll need to update the security document

@iamanishx
Copy link

I just saw the document. @iamanishx What is the BFF approach? I remember seeing the document. Please post the link here.

https://docs.google.com/document/d/1465DpM1G1eNqJKjBjIvyvMjbnL3LcfiYPZw9fgait_Q/edit?tab=t.0

here it is

@im-vedant
Copy link
Author

@iamanishx
Copy link

iamanishx commented Mar 1, 2025

PalisadoesFoundation/talawa-admin#3755
this was the opened issue .

this the issue opend for this and we are working on this . a minimal fastify bff server has been made and we are able make api calls from localhost admin to make api calls to test.talawa.io/graphql without any cors issue .

for making proper authorized calls in between bff server and api we will use mTLS approach .

the rate-limiting can be done properly within the BFF server .

@im-vedant
Copy link
Author

@iamanishx We need to consider mobile version too. For that need to implement API rate limiting in talawa api.

@iamanishx
Copy link

@iamanishx We need to consider mobile version too. For that need to implement API rate limiting in talawa api.

yes good point as there is no issue of cors in between mobile and api it would be better not to include the BFF server between them .

Copy link

github-actions bot commented Mar 9, 2025

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Mar 9, 2025
@palisadoes
Copy link
Contributor

Unassigned. Inactivity

@im-vedant
Copy link
Author

@palisadoes I am working on it. Last week my exams were going on. I have made significant progress. Will raise a pr in 2-3 days.

@github-actions github-actions bot removed the no-issue-activity No issue activity label Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature request security Security fix test Testing application
Projects
Status: Backlog
Status: Backlog
Development

No branches or pull requests

6 participants