Identification of Post Attachment (Priority for test.talawa.io)

[JaiPannu-IITI]

Describe the bug

Post Attachments does not have id to distinguish a particular post.

Note: postId refers to ID of the actual post it is attachment to, it can be same for multiple attachments

To Reproduce

Steps to reproduce the behavior: Analyze postAttachments schema

Expected behavior

Each post_attachment should have a unique ID assigned to it.

Approach

Add unique identifier of the post_attachment and adjust related sections (except sample data script and sample data) to avoid code breakage.

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

• Student Internship Programs talawa#359

[PratapRathi]

@palisadoes Please assign this issue to me.

I was assigned 2 issues but I completed the task and raised PR, please review and close them.
#3300
#3310

[prayanshchh]

why do we need unique ids for attachement

1. post attachements are only needed when posts are viewed
2. for this use case querying all attachements based on postId is enough
3. for every post attachement the name of the post is stored as ulid() in mutation (if i am not wrong)
4. in sample data we only have 6 posts having images, why do I see more

[JaiPannu-IITI]

1. There must be any unique field.
2. How would you delete any particular attachment if you want?
3. One cannot remove sample data duplication without unique id without ignoring business logic since we are directly interacting with database.

[prayanshchh]

1. if someone deletes a post all the attachements related to post can be deleted using postId, do we need a feature to delete a specific attachement from a post, we may not need it
2. in develop loadSampledata would delete all records in related collections in db and import them again, making sure no matter how many times the import command is run, it doesn't throw a duplicate key error

[JaiPannu-IITI]

Please once check how sample data script works

[palisadoes]

@prayanshchh

1. We need to consider deduplication.
   1. https://en.wikipedia.org/wiki/Data_deduplication
2. One approach is to create a hash of the object that is being uploaded. If there is a match with a file already stored, then the post is updated with the pointer to the original object. The uploaded object is discarded as unnecessary.
3. The object is not deleted until all pointers to it are removed.
4. This also helps when people are forwarding posts. There is no need to recreate the object for everyone who receives the message

[github-actions]

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.