Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoMongo : Add query for joined organization and mutations for block organizations #3329

Open
khushipatil1523 opened this issue Mar 2, 2025 · 22 comments
Assignees

Comments

@khushipatil1523
Copy link

Is your feature request related to a problem? Please describe.
Currently, there are no GraphQL queries for joinedOrganization and mutations to manage blocked organizations. This limits functionality for users who need to join or block organizations.

Description
In this PR, I will be adding GraphQL queries for joined organization and mutations for managing blocked organizations. This enhancement will provide users the ability to:

  1. Block an organization (blockOrganization mutation).
  2. Retrieve a list of joined organizations (joinedOrganizations query).
  3. Retrieve a list of blocked organizations (blockedOrganizations query).
  4. The implementation will follow existing GraphQL patterns, ensuring consistency, proper error handling, and input validation.

**Approach to be followed **
Same as used for other components, adhering to the current schema and resolver structure.

@khushipatil1523
Copy link
Author

@palisadoes can i work on this?

@palisadoes palisadoes removed the unapproved Unapproved for Pull Request label Mar 2, 2025
@khushipatil1523 khushipatil1523 changed the title NoMongo : Add mutations and query for joined organization and block organizations NoMongo : Add query for joined organization and mutations for block organizations Mar 2, 2025
@gkbishnoi07
Copy link

Hi @khushipatil1523, I've already created the joinedOrganization query for issue PalisadoesFoundation/talawa-admin#3565 You can add other mutations membership or the blockOrganization query as needed.

@khushipatil1523
Copy link
Author

Hi @khushipatil1523, I've already created the joinedOrganization query for issue PalisadoesFoundation/talawa-admin#3565 You can add other mutations membership or the blockOrganization query as needed.

Is the "Join" button working after you create the joinedOrganization query?

@gkbishnoi07
Copy link

gkbishnoi07 commented Mar 3, 2025

Hi @khushipatil1523, I've already created the joinedOrganization query for issue PalisadoesFoundation/talawa-admin#3565 You can add other mutations membership or the blockOrganization query as needed.

Is the "Join" button working after you create the joinedOrganization query?

almost, I'm working on it. For the join button, I added the joinPublicOrganization mutation, as seen in the develop branch.

develop-postgres
Image

Image

develop

Image

@gkbishnoi07
Copy link

@khushipatil1523 also we have to add sendMembershipRequest Mutation are you working on it?

@khushipatil1523
Copy link
Author

Hi @khushipatil1523, I've already created the joinedOrganization query for issue PalisadoesFoundation/talawa-admin#3565 You can add other mutations membership or the blockOrganization query as needed.

Is the "Join" button working after you create the joinedOrganization query?

No, I'm working on it. For the join button, I need to add the joinPublicOrganization mutation, as seen in the develop branch.

develop-postgres Image

Image

develop

Image

I’m currently working on the issue: PalisadoesFoundation/talawa-admin#3197. During testing, the join button is failing, and I’m unable to merge my PR. I want to complete it as soon as possible. I’ve already implemented the mutation, and it’s working. However, there is no mutation for the join functionality currently present in the API. I also checked and found that there’s no open issue for the join organization functionality, which is why I created this one.

this is mutation for joinpublicorganization:

Image

data is updated in organizationmembershiptable after running mutation:

Image

Now, there are two functionalities remaining: membership requests mutation for private organizations and canceling membership requests mutation. If you don’t mind, can I proceed with them?

@khushipatil1523
Copy link
Author

@khushipatil1523 also we have to add sendMembershipRequest Mutation are you working on it?

Yes, I’m working on it. We need to update the OrganizationTable to add a userRegistrationRequired column, which will be used to determine whether the organization is public or not. This will also be covered in this issue.

@gkbishnoi07
Copy link

@khushipatil1523 Alright, you can go ahead with them. However, could you please inform me when the joinPublicOrganization mutation get merged? I need this mutation as soon as possible.

@khushipatil1523
Copy link
Author

@khushipatil1523 Alright, you can go ahead with them. However, could you please inform me when the joinPublicOrganization mutation get merged? I need this mutation as soon as possible.

i also want complete it ASAP i will inform you when this issue get merged

@gkbishnoi07
Copy link

@khushipatil1523 Alright, you can go ahead with them. However, could you please inform me when the joinPublicOrganization mutation get merged? I need this mutation as soon as possible.

i also want complete it ASAP i will inform you when this issue get merged

can we connect on slack ?

@khushipatil1523
Copy link
Author

@khushipatil1523 Alright, you can go ahead with them. However, could you please inform me when the joinPublicOrganization mutation get merged? I need this mutation as soon as possible.

i also want to complete it ASAP i will inform you when this issue get merged

@gkbishnoi07
Copy link

@khushipatil1523 Alright, you can go ahead with them. However, could you please inform me when the joinPublicOrganization mutation get merged? I need this mutation as soon as possible.

i also want to complete it ASAP i will inform you when this issue get merged

Thanks, I'll wait until it's merged.

@iamanishx
Copy link

join organization button will work after ur PR i think ?

@gkbishnoi07
Copy link

join organization button will work after ur PR i think ?

After this PR we are able to join organizations

@iamanishx
Copy link

join organization button will work after ur PR i think ?

After this PR we are able to join organizations

join now button will send a request to admin for approval of joining the organization right ?

@gkbishnoi07
Copy link

In public organizations we can directly join organization but in private organizations it send a request for approval from admin to join organizations

@khushipatil1523
Copy link
Author

In public organizations we can directly join organization but in private organizations it send a request for approval from admin to join organizations

join organization button will work after ur PR i think ?

After this PR we are able to join organizations

join now button will send a request to admin for approval of joining the organization right ?

yes but if organization is private

@iamanishx
Copy link

In public organizations we can directly join organization but in private organizations it send a request for approval from admin to join organizations

yupp meant the same
i have the issue of membership approval so i will wait untill this PR get merged

@iamanishx
Copy link

Guys if am not wrong we need to make a table for membership requests cozz there is nothing abt membership request . So join now button will use the mutation for it . I can help you out guys cozz i also need my work to get finished within 1-2 days

@khushipatil1523
Copy link
Author

Guys if am not wrong we need to make a table for membership requests cozz there is nothing abt membership request . So join now button will use the mutation for it . I can help you out guys cozz i also need my work to get finished within 1-2 days

already implement this in pr #3341

@palisadoes
Copy link
Contributor

  1. How's progress on this? It needs to be completed as a GSoC prerequisite.
  2. The PR is closed

@bandhan-majumder
Copy link

Do you need any help @khushipatil1523 to fast forward the fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

5 participants