Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API - Remove Legacy Plugin Code #3337

Open
meetulr opened this issue Mar 4, 2025 · 10 comments
Open

API - Remove Legacy Plugin Code #3337

meetulr opened this issue Mar 4, 2025 · 10 comments
Assignees
Labels
cleanup Remove non-functional or unnecessary code GSoC Priority

Comments

@meetulr
Copy link
Contributor

meetulr commented Mar 4, 2025

Describe the issue

The current plugin system does not meet our requirements in terms of functionality and scalability. We plan to implement an intuitive, robust and scalable plugin architecture with this GSoC project.

Describe the solution

Remove any existing code related to the plugin functionality.

Additional Context

Companion issue: PalisadoesFoundation/talawa-admin#3793

@github-actions github-actions bot added the unapproved Unapproved for Pull Request label Mar 4, 2025
@meetulr meetulr removed the unapproved Unapproved for Pull Request label Mar 4, 2025
@hustlernik
Copy link

@meetulr Please assign this issue.

@hustlernik
Copy link

I have done some research on plugin architecture, after creating a draft, I will share with you soon.

@hustlernik
Copy link

Also currently assigned issue to implement block functionality is almost done, so I will raise PR for that today.

@meetulr meetulr added the cleanup Remove non-functional or unnecessary code label Mar 4, 2025
@bandhan-majumder
Copy link

@meetulr assign please

@meetulr
Copy link
Contributor Author

meetulr commented Mar 4, 2025

@hustlernik, you’re already assigned to 3 issues. Our policy allows a maximum of 2 issues per contributor.

@bandhan-majumder
Copy link

@meetulr I think the current codebase of talawa-api has no plugin support by default. Nothing else is there to remove. The plugins it has right now are for Fastify which are irrelevant than the scope of the issue. Can you please take a look once

@meetulr
Copy link
Contributor Author

meetulr commented Mar 6, 2025

Look in the develop branch, remove the plugin functionality from there.

@bandhan-majumder
Copy link

@meetulr I think I am a bit confused. Can you please clarify the doubts here;

  1. Should I remove the code for develop or develop branch.
  2. Should I do the same for develop or develop-postgres from talawa-admin

The plugin features are not migrated to postgres in develop-postgres as maybe they are broken. So @xoldd ignored them.

@meetulr
Copy link
Contributor Author

meetulr commented Mar 6, 2025

The issue is for removing the code from the develop branch in the api.

And since it's present in both the branches in admin, you should remove it from both. So for admin, you can raise two prs, one for each branch.

@bandhan-majumder
Copy link

@meetulr okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Remove non-functional or unnecessary code GSoC Priority
Projects
None yet
Development

No branches or pull requests

3 participants