-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add publish command #182
base: master
Are you sure you want to change the base?
Conversation
|
Hi, nice PR, but I need more time to review it. I'll try to complete it by the end of the month. |
Hi @Donovan-Ye can you add some test for this feature? |
yeah, of course, I will try to add some tests. |
Hi @iosh, I have added tests for the publish command. Please review them when you have time ~ |
Hi @Donovan-Ye Sorry for keeping you waiting. This PR only implements the "publish" command, lacking support for other options such as -t, -a, -o, etc. I have looked at the implementation of pnpm and found a plugin |
You are right. Let me have a look at the |
I have a brief look at the plugin, I believe we can achieve our "publish" command base on it. However, many internal functions are dependent on pnpm. We will need to either develop these functionalities ourselves or seek an alternative solution. But for sure, we can follow their ideas. |
Waiting for your good news and let me know if you need any help |
Hi @Donovan-Ye , I have read the changeset source code, I think we can implement like this : https://github.com/changesets/changesets/blob/main/packages/cli/src/commands/publish/npm-utils.ts#L237 |
Trying to add the missing
publish
command as listed in README.md.