Rework mappings to match vanilla setup #602
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zemurin
reviewed
Nov 27, 2024
| link = { vic3 = theravada eu4 = buddhism } | ||
| link = { vic3 = sikh eu4 = sikhism } | ||
| link = { vic3 = hindu eu4 = hinduism } | ||
| link = { vic3 = shinto eu4 = shinto } | ||
| #link = { vic3 = shinto eu4 = shinto } Match vanilla setup |
There was a problem hiding this comment.
Wait, why exactly would we be doing this? What's the benefit of historical setup over our direct mappings which are more detailed?
There was a problem hiding this comment.
The Shinto in Vic3 seems to represent State Shinto which was developed as a result of the Meiji Restoration. Because there's a decision to flip to Shinto once you overthrow the Shogunate in vanilla, and that there's no reason I could find to see why that specific decision wouldn't appear in a converted game, it makes more sense for EU4 Shinto to start off as Mahayana. If EU4 Japan restores the emperor, they can flip to Shinto by decision upon conversion to Vic3, which the AI will most likely do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.