Split IOutboxStorage into 2 interfaces

[synhershko]

In Particular/NServiceBus.RavenDB#43 (comment) we've stumbled upon a possible friction point with external storages, as one method (Store) requires a shared session (via session provider) and the rest create their own separate sessions.

This creates a friction point as the persister requires both a session provider and a DB connection (DocumentStore in RavenDB's case), and there are some edge cases where the 2 may point to different DBs.

To avoid this, @andreasohlund suggested we split IOutboxStorage into 2 - the deduplicator side of things (Store) into one and the rest into another.

[SzymonPobiega]

👍 I notices the same when working with NHibernate one

[danielmarbach]

Is this still on the radar?

[andreasohlund]

Think it's a good change, not sure about how urgent it is though

On Mon, Apr 20, 2015 at 10:40 AM, Daniel Marbach [email protected]
wrote:

Is this still on the radar?

—
Reply to this email directly or view it on GitHub
#2659 (comment)
.

[SzymonPobiega]

I like the change. It would even more important if we decide to go for explicit context sharing between handlers because that context would only need to access the store method.

[andreasohlund]

I guess we would then pass a "context" to the Store to avoid needing DI.

I'm sold :)

On Mon, Apr 20, 2015 at 1:08 PM, Szymon Pobiega [email protected]
wrote:

I like the change. It would even more important if we decide to go for
explicit context sharing between handlers because that context would only
need to access the store method.

—
Reply to this email directly or view it on GitHub
#2659 (comment)
.

[danielmarbach]

@DavidBoike should we close this one because it is tracked in feature dev?

[DavidBoike]

How would that affect potential future release notes?

[danielmarbach]

Good point. Then leave it open. There seems to be a lot of redundancy going on with feature dev and issues in this repo. But what is worse: Some things here aren't tracked yet.

[DavidBoike]

This is not really in progress, I think it's here only because of how NSB repo was brought into Waffle. Where should this go?

[DavidBoike]

Nevermind, I found its friends. All moved back to the Backlog, and I'll be removing my face as there is no current plan to do this soon.