Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only pass MessageType as string to ISubscriptionStorage #4175

Open
andreasohlund opened this issue Sep 29, 2016 · 0 comments
Open

Only pass MessageType as string to ISubscriptionStorage #4175

andreasohlund opened this issue Sep 29, 2016 · 0 comments

Comments

@andreasohlund
Copy link
Member

Given that we now ignore the version we can simplify ISubscriptionStorage.X to:

 public interface ISubscriptionStorage
    {
        Task Subscribe(Subscriber subscriber, string messageType, ContextBag context);

        Task Unsubscribe(Subscriber subscriber, string messageType, ContextBag context);

        Task<IEnumerable<Subscriber>> GetSubscriberAddressesForMessage(IEnumerable<string> messageTypes, ContextBag context);
    }

we can also remove the MessageType class in the core since it adds no value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant