Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flashing text when re-sharing battle #450

Open
Paul-Ladyman opened this issue Aug 25, 2022 · 0 comments
Open

Flashing text when re-sharing battle #450

Paul-Ladyman opened this issue Aug 25, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@Paul-Ladyman
Copy link
Owner

Paul-Ladyman commented Aug 25, 2022

When a battle is shared a placeholder '. . .' is shown before the player session link is displayed. This is mainly done to cover the time required to communicate with AWS AppSync.

However the placeholder is also shown until the the player session link has been copied to the clipboard. If the DM stops sharing the battle and then starts sharing again, we do not trigger the call to AppSync again. This means on the second share the placeholder is only shown whilst the link is copied, which is very quick and gives the effect of the link blinking or flashing on the screen when it is displayed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant