Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Significant lag in CLI #76

Closed
markkvdb opened this issue May 17, 2020 · 5 comments
Closed

Significant lag in CLI #76

markkvdb opened this issue May 17, 2020 · 5 comments

Comments

@markkvdb
Copy link
Collaborator

Significant lag in CLI

Description

Hi all,

Installing the latest version of JobFunnel and running funnel --help takes a few seconds when opening the first time. Later calls are slightly faster but are arguable still a tad slow.

I know I could have looked into the cause of the problem right now but I'm really low on time as of lately. If this issue still persists when I have more time I will come back to this (kind of a reminder for myself then).

Steps to Reproduce

  1. Fresh install of JobFunnel
  2. Call funnel --help
  3. Wait

Expected behavior

A few ms delay before showing CLI help information.

Actual behavior

Significant delay between function call and presented info.

Environment

@thebigG
Copy link
Collaborator

thebigG commented May 18, 2020

That's very strange. I doubt the changes I made will affect the --help prompt's speed. Will be looking into this further when I have time.

@PaulMcInnis
Copy link
Owner

PaulMcInnis commented May 19, 2020

I think this has to do with dependencies mostly, it may be avoided with doing more importing after we do arg-parsing.

It makes sense that it is slower since we have grown in dependencies

👍 for noticing this behavior that might discourage new users.

@markkvdb
Copy link
Collaborator Author

@thebigG it has not been caused by your recent changes. I think it has been here for a long time tbh. Yes, it probably has something to do with the parsing step but this is odd to me, since we are not doing that much parsing to begin with.

@PaulMcInnis
Copy link
Owner

python gets bogged down doing imports before it gets to parsing is my suspicion.

@PaulMcInnis
Copy link
Owner

CLI is acceptably fast at this point in time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants