Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix Included] Google Chrome Driver undefined #78

Closed
phcreery opened this issue Jun 12, 2020 · 2 comments
Closed

[Fix Included] Google Chrome Driver undefined #78

phcreery opened this issue Jun 12, 2020 · 2 comments

Comments

@phcreery
Copy link

Description

Google Chrome Driver not defined

Steps to Correct

Replace line 158 of jobfunnel/tools/tools.py
webdriver.Chrome(ChromeDriverManager().install())
with
driver = webdriver.Chrome(ChromeDriverManager().install())
so function get_webdriver() has a value to return.

Why not a pull request? Too small of a fix

Environment

  • Installed Commit: cb9f152
  • Operating system and version: Windows 10
  • Browser: Google Chrome
@thebigG
Copy link
Collaborator

thebigG commented Jun 12, 2020

I fixed this actually in my last PR #75
I was the one that forgot that assignment 😅
We're still in the middle of evaluating that PR so I hope we merge those changes soon!
Thanks so much for bringing this to our attention!

@phcreery
Copy link
Author

Awesome!!
My apologies for not researching before submitting an issue.
Will close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants