Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: MMRL confuses ReZygisk with ZygiskNext #113

Open
3 tasks done
Keyaku opened this issue Jan 13, 2025 · 5 comments
Open
3 tasks done

[BUG]: MMRL confuses ReZygisk with ZygiskNext #113

Keyaku opened this issue Jan 13, 2025 · 5 comments
Labels
bug Something isn't working confirmed This issue or pull request is confirmed to be done.

Comments

@Keyaku
Copy link

Keyaku commented Jan 13, 2025

Version

1.0.0-rc.1

Modules

ZygiskAssistant by snake-4 version 213

Description

The Magisk module manager MMRL is confusing ReZygisk with Zygisk Next. I'm guessing it's because MMRL uses the shoddy method of looking up its ID (and the module.prop's id value shows zygisksu) when no repo is available, but haven't checked.
It marks the module as updatable which, upon checking the changelog, it's clear it points to the latest Zygisk Next package.

Clearing MMRL's storage (since this app is prone to issues with its cache) only unmarked the module from blacklist; not sure if this is relevant.

Steps to reproduce

  1. Have root with Apatch.
  2. Have MMRL installed (and obviously ReZygisk).
  3. In Modules tab, check if ReZygisk presents an enabled "Update" button.
  4. Go to Zygisk Next's package page from Googler's repo.
  5. Check if the buttons show "Remove" and "Update".

Logs

No response

Confirmations

  • My environment meets the minimum requirements.
  • I have verified that this is not a duplicate issue.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Keyaku Keyaku added bug Something isn't working not confirmed This issue or pull request is not confirmed to be done. labels Jan 13, 2025
@Keyaku
Copy link
Author

Keyaku commented Jan 13, 2025

By the way, the Modules section of your GitHub issue report lacks clarity; is it Zygisk-specific modules, or any and all Magisk modules?

@ThePedroo
Copy link
Member

Can depend from the case but unless all modules information might be relevant, only Zygisk ones.

As part of that issue, we plan to eventually change the module id to avoid conflicts like that one, but in the meanwhile, while we fix other more important things, nothing can be done.

@ThePedroo ThePedroo added confirmed This issue or pull request is confirmed to be done. and removed not confirmed This issue or pull request is not confirmed to be done. labels Jan 13, 2025
@Keyaku
Copy link
Author

Keyaku commented Jan 13, 2025

No worries, it is indeed a rather minor issue, and very easy to avoid.

@DerGoogler
Copy link

DerGoogler commented Jan 25, 2025

That is not a bug. That is because the modules using the same module ID.

@Keyaku
Copy link
Author

Keyaku commented Jan 26, 2025

That is not a bug. That is because the modules using the same module ID.

Yep, that is what I mentioned. The "bug" (issue, more like) is on this module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed This issue or pull request is confirmed to be done.
Projects
None yet
Development

No branches or pull requests

3 participants