Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle users editing/deleting messages with conversions #58

Open
Phanabani opened this issue Jul 20, 2021 · 1 comment
Open

Handle users editing/deleting messages with conversions #58

Phanabani opened this issue Jul 20, 2021 · 1 comment
Assignees
Labels
major feature A big new feature, probably the focus of a major version bump

Comments

@Phanabani
Copy link
Owner

When a user edits a conversion, Sandpiper should pick up on this and edit her reply with the new conversion. Likewise, if a user deletes their message with a conversion, she should delete her reply. The deletion could also be a config field.

@Phanabani Phanabani added the enhancement New feature or request label Jul 20, 2021
@Phanabani
Copy link
Owner Author

I started work on this a while ago and implemented it with a per-channel cache to map messages to Sandpiper replies. This is good because she doesn't need to fetch messages to find her reply, but the downside is that the cache is in-memory only, so she'll lose it on restarts, which I think defeats the purpose.

I think then I will use the fetch method. When a message is edited/deleted, fetch messages forward in time until it finds her reply (with a limit). This operation may be ambiguous if two people did a conversion at the same time, so I think we should use #56 to definitively get the correct reply.

@Phanabani Phanabani added major feature A big new feature, probably the focus of a major version bump and removed enhancement New feature or request labels Nov 7, 2021
@Phanabani Phanabani self-assigned this Jul 31, 2022
@Phanabani Phanabani moved this from In progress to Paused in Sandpiper v2.0.0 - Thread support Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major feature A big new feature, probably the focus of a major version bump
Development

No branches or pull requests

1 participant