Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List selections should be different colors when focused vs blurred #172

Open
michaelgundlach opened this issue Jan 6, 2022 · 7 comments
Labels
Area: Workbench Related to the IDE Workbench Enhancement New feature or request

Comments

@michaelgundlach
Copy link
Contributor

The
attached screenshot
shows how difficult it is to know what context I'm in, when 4 different items are all selected and colored orange. I keep trying to do actions and being surprised that they don't work, or misunderstanding the context of a Property Section.

  • Am I working with the dino file or the dino Scene object?
  • Am I in Level.scene or Preload.scene?
  • Why am I selecting the dino block but seeing a giant guapen in the Properties pane?

Either selections should be limited to one item at a time in the entire Workbench (so clicking e.g. the dino block would unselect Preload.scene in the Files view etc), or non-focused selections should get their own color e.g. greyish-orange in the Dark theme (so the dino block would be selected orange and Preload.scene in the Files view would be selected greyish-orange.)

@PhaserEditor2D
Copy link
Owner

The workbench's active part is highlighted. In that image, the Files view is the one selected.
The Inspector view is always connected to the selection of the active part (Files view in the image above).
But I agree that changing the color of the selection of a non-active part is less confusing.

@michaelgundlach
Copy link
Contributor Author

The active Workbench part may be highlighted, but I cannot tell which one is highlighted even by looking at my own screenshot right now. The highlighting is too subtle, I guess. I did see that highlighting subtly changed as I selected different parts of the Workbench, but it wasn't enough to tell my brain to pay attention to that part.

After looking at the Inspector carefully I realize the Files view must be highlighted, so I guess the fact that its background is the same light background as the Blocks.Images panel means it is selected. Besides the unselected and selected gray being very similar, the unselected Blocks.Images background being the same as the selected color makes it even more difficult to figure out.

@PhaserEditor2D
Copy link
Owner

Look at the top border of the Files tab. It is orange, it is highlighted. But ok, I agree the whole view could be lighter.

image

@PhaserEditor2D
Copy link
Owner

With the Light Blue theme I think it is more explicit.

@michaelgundlach
Copy link
Contributor Author

Ah! I do see the section highlight line.

I think really the bright orange (or blue) selection is enough to show the user what is focused, as it stands out so well. Just changing the "selected in an inactive part of the Workbench" color should be all that's needed.

@PhaserEditor2D
Copy link
Owner

Yes. The only "problem" with it is that each time you select a new part the IDE has to re-render all the other parts based on viewers. But it is fine. I will think about this.

@michaelgundlach
Copy link
Contributor Author

Hmm... I was going to suggest you rely on the .activePart CSS hint, but I see that the selected items are drawn in a canvas, not using HTML. Well, good luck :)

@PhaserEditor2D PhaserEditor2D added Enhancement New feature or request Area: Workbench Related to the IDE Workbench labels Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Workbench Related to the IDE Workbench Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants