Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger disable/enable dataOnExternalStorage on settings import #231

Open
andiandi13 opened this issue Jan 13, 2025 · 1 comment · May be fixed by #239
Open

Trigger disable/enable dataOnExternalStorage on settings import #231

andiandi13 opened this issue Jan 13, 2025 · 1 comment · May be fixed by #239
Assignees
@PhilKes
Labels
bug Something isn't working v6.4.0

Comments

@andiandi13
Copy link
Contributor

What happened?

If you import a JSON setting file on the first app installation, after creating notes/lists/labels etc. (or importing a backup ZIP), all data will be cleared.

After the first time, it doesn't happen again afaik.

Steps to reproduce :

  • Install the app or clear data of previous installation
  • Creates notes or import backup
  • Import settings
  • Everything is gone

App Version

6.4.0-BETA

Android Version

29

(Optional) Relevant log output

No response
@andiandi13 andiandi13 added the bug Something isn't working label Jan 13, 2025
@andiandi13
Copy link
Contributor Author

Update :After some testing, I exactly understand what happens.

In fact, nothing is erased, but if you import a JSON file with "dataOnExternalStorage":true inside, database relocation from data/data to Android/media won't be trigger, the app will try to load database in Android/media folder, but since it's empty, everything will disappear from the app.

You have to switch the "Store data on external storage" setting back to "Disabled" in the app, the to "Enabled" again so that database will be moved to Android/media.

In short, NotallyX should check if the JSON have "dataOnExternalStorage":true, and if so, trigger the file relocation to Android/media while importing settings.

@PhilKes PhilKes changed the title Import settings can clear all data Trigger disable/enable dataOnExternalStorage on settings import Jan 13, 2025
@PhilKes PhilKes linked a pull request Jan 14, 2025 that will close this issue
Open
@PhilKes PhilKes self-assigned this Jan 14, 2025
@PhilKes PhilKes added the v6.4.0 label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhilKes PhilKes

Labels
bug Something isn't working v6.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Trigger moving database if dataOnExternalStorage changed by import PhilKes/NotallyX
2 participants
@andiandi13 @PhilKes