Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Biometric lock for devices without/with broken fingerprint #247

Open
PhilKes opened this issue Jan 16, 2025 · 3 comments
Open

Biometric lock for devices without/with broken fingerprint #247

PhilKes opened this issue Jan 16, 2025 · 3 comments
Labels
enhancement New feature or request

Comments

@PhilKes
Copy link
Owner

PhilKes commented Jan 16, 2025

Check if biometric lock works as intended if the device only offers PIN/Pattern device lock

@PhilKes PhilKes added the enhancement New feature or request label Jan 16, 2025
@andiandi13
Copy link
Contributor

andiandi13 commented Jan 17, 2025

I was curious about that, so I installed LDPlayer, which has an Android 9 without biometric option, and when I try to enable biometric app lock, I get the message "No biometric features avalaible on that device" even though I have a PIN code set on this virtual device.

In short, it seems like we can't secure the app with PIN/Pattern.

That being said, I was thinking about adding an internal PIN lock to secure the app, independent on what the device have. We could have two options :

  • System biometrics lock (uses fingerprint - and PIN/Pattern if you can fix that)
  • App PIN code

@PhilKes
Copy link
Owner Author

PhilKes commented Jan 26, 2025

I think android distincts between biometrics and PIN/Pattern, but both can be used for the BiometricPrompt, I think the checks I implemented in the app just check for Biometrics, and on lower Android Versions I think that returns that the device doesnt have any biometric features

I dont want to introduce a self-implemented PIN, its just too much hassle for something android already provides.

@andiandi13
Copy link
Contributor

Ok I understand. As long as PIN code only can be used from Android 5 (Pie), this is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants