Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move checked / unchecked items in list #251

Closed
andiandi13 opened this issue Jan 17, 2025 · 2 comments · Fixed by #320
Closed

Move checked / unchecked items in list #251

andiandi13 opened this issue Jan 17, 2025 · 2 comments · Fixed by #320
Labels

Comments

@andiandi13
Copy link
Contributor

  1. Move checked item to bottom of the list. Because mixing unchecked and checked items can be confusing when doing tasks like shopping, it takes time to scroll through long lists and we may miss some items.

  2. Move unchecked items to the top of the list
    (In my case I re-use the same grocery list, so I uncheck what I wanna buy every time)

This can be added by default, or as two separate options to please everyone I guess.

@andiandi13 andiandi13 added the enhancement New feature or request label Jan 17, 2025
@PhilKes
Copy link
Owner

PhilKes commented Jan 23, 2025

Actually that was one of the first features I implemented, but the implementation got much harder with the introduction of child items in lists. The implementation to sort by checked list-items is still in the code, its just hidden to the user since it was buggy. The most annoying part was the drag and drop of items, and if you drag a "parent" item you obviously want to drag it's child items with it, which got quite messy to debug. But I definetely want to re-introduce this feature when I find the time.

My implementation was based on Google Keep's behaviour, where checked items are always below unchecked ones, but it maintains the relative order of the items, meaning if you uncheck a checked item it goes to the same position as it was before it was checked

@andiandi13
Copy link
Contributor Author

andiandi13 commented Jan 23, 2025

Actually that was one of the first features I implemented, but the implementation got much harder with the introduction of child items in lists. The implementation to sort by checked list-items is still in the code, its just hidden to the user since it was buggy. The most annoying part was the drag and drop of items, and if you drag a "parent" item you obviously want to drag it's child items with it, which got quite messy to debug. But I definetely want to re-introduce this feature when I find the time.

My implementation was based on Google Keep's behaviour, where checked items are always below unchecked ones, but it maintains the relative order of the items, meaning if you uncheck a checked item it goes to the same position as it was before it was checked

I can imagine how tricky it can be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants