Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend notes colors to full screen #264

Closed
andiandi13 opened this issue Jan 19, 2025 · 5 comments · Fixed by #265
Closed

Extend notes colors to full screen #264

andiandi13 opened this issue Jan 19, 2025 · 5 comments · Fixed by #265
Labels
enhancement New feature or request v7.0.0 Reminders, List note fixes, Auto Backups

Comments

@andiandi13
Copy link
Contributor

When a note is colored, the top and bottom of the screen do not change :

Image

In the original Notally app it does

Image
https://github.com/OmGodse/Notally

@andiandi13 andiandi13 added the enhancement New feature or request label Jan 19, 2025
@PhilKes
Copy link
Owner

PhilKes commented Jan 19, 2025

Also mentioned in #175

@PhilKes
Copy link
Owner

PhilKes commented Jan 19, 2025

I did start implementing it but since this included a lot of small changes to make it consistent (e.g. EditText cursor/seleciton colors, bottom sheets when pressing ("+", or "..."), Search bar,... I just stopped because I didnt really know if people cared that much.
Already finished implementing it, PR incoming

@andiandi13
Copy link
Contributor Author

Nice ! It looks way more natural without two big white/black bars

@PhilKes PhilKes added the v7.0.0 Reminders, List note fixes, Auto Backups label Jan 19, 2025
@PhilKes
Copy link
Owner

PhilKes commented Jan 19, 2025

@andiandi13 From now on I will release BETA version during development. I create a new so called build type for this, so that if you install a BETA version its like a spearate app with its own data etc. For more info see https://github.com/PhilKes/NotallyX?tab=readme-ov-file#beta-releases . With this you can test it more easily without possibly loosing/messing up your own data.

@andiandi13
Copy link
Contributor Author

andiandi13 commented Jan 19, 2025

@PhilKes That's great, I was about to ask if you could do nightly builds to test new features, but this is a nice alternative as well !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v7.0.0 Reminders, List note fixes, Auto Backups
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants