Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove delete option from top bar since it's already in the bottom more menu #316

Open
andiandi13 opened this issue Jan 26, 2025 · 4 comments · May be fixed by #329
Open

Remove delete option from top bar since it's already in the bottom more menu #316

andiandi13 opened this issue Jan 26, 2025 · 4 comments · May be fixed by #329
Assignees
Labels
enhancement New feature or request v7.1.0

Comments

@andiandi13
Copy link
Contributor

Many android apps have three dot menu in the top right corner of the screen.

In NotallyX I often click in this corner to open the menu by reflex and it deletes the note (yes I can undo, but it get out of the note and it's a bit annoying)

Pinning by accident > deleting by accident :)

@andiandi13 andiandi13 added the enhancement New feature or request label Jan 26, 2025
@PhilKes PhilKes changed the title Invert trash bin icon and pin icon Swap trash bin icon and pin icon Jan 27, 2025
@PhilKes
Copy link
Owner

PhilKes commented Jan 27, 2025

Perhaps a better solution would be to show a delete confirmation dialog which you can then just cancel out of again?

@andiandi13
Copy link
Contributor Author

It's a solution for sure, even though I don't think it's the best idea to keep a delete button in this area, but if you want to keep it there with the confirmation dialogue, that'll do

@PhilKes
Copy link
Owner

PhilKes commented Jan 28, 2025

I just now realized that there are 2 delete buttons, which wasnt intended by me, one in top right corner and one in the bottom "..." menu
So we could just remove the top right delete button.
I personally dont have a preference where the delete button should be

@andiandi13
Copy link
Contributor Author

@PhilKes Ah I just realized it too lol
Yes its better imo

@PhilKes PhilKes changed the title Swap trash bin icon and pin icon Remove delete option from top bar since it's already in the bottom more menu Jan 29, 2025
@PhilKes PhilKes linked a pull request Jan 29, 2025 that will close this issue
@PhilKes PhilKes self-assigned this Jan 29, 2025
@PhilKes PhilKes added the v7.1.0 label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v7.1.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants