-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If auto-sort list by checked items is enabled, separate checked items list #371
Comments
@andiandi13 I just added a custom NotallyX-7.1.0-BETA-CheckedList.apk to the latest BETA release. |
@PhilKes Thank you 👍 |
I'll post bugs I found here as I test the app by editing this post
PS : I like the fact that items are instantly send below/above when checked/unchecked. Before we could see them "falling" more or less faster depending on their position, and it wasn't looking very nice, but I think it's a consequence of this bug.
Check 4, then move 3 outside of the subtask group, like that :
Only 4 will be checked, when it's supposed to refresh, check 2, and send both to the checked view.
|
@andiandi13 Tried to fix all your points, except |
@PhilKes Thank you. I see that you only reduced the margin for unchecked items, so it's still hard to delete items when scrollbar is overlapping |
The drag handle margin has no effect on the position of the delete button, what screen size do you have? Because there is lots of space to the delete button on my emulator (6.1") and personal device: ![]() Note: I enabled the visibility of the drag handle here for test purposes |
@PhilKes Google Pixel 4a 5.81" - 443dpi Look how hard it is (the video is cut a bit earlier but it get delete just after when I tap a bit more left) deleteicon.mp4 |
Describe the solution you'd like
Currently if you use "Sort checked items to the end" for the list auto-sort, the checked items are moved to the end of the list, but kept in the same
RecyclerView
. This leads to a much more complex implementation for dragging and sorting, therefore the lists should be split into unchecked and checked items to simplify the implementation. This would also make the code less error-prone, since it has potential for lots of bugs, see e.g. #361 #357 #362, etc.Additional context
Google Keep also separates checked from unchecked:
The text was updated successfully, but these errors were encountered: