Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expect loading a changemaker by taxId to be many, not one #1128

Open
bickelj opened this issue Jul 31, 2024 · 0 comments
Open

Expect loading a changemaker by taxId to be many, not one #1128

bickelj opened this issue Jul 31, 2024 · 0 comments

Comments

@bickelj
Copy link
Contributor

bickelj commented Jul 31, 2024

As of ef3174e, organization is unique not solely by taxId (formerly externalId), but by the combination of taxId and name. This is well and good. Except loadOrganizationByTaxId and its caller seem to expect one row at the moment. So those functions probably need an update to include name or expect a list.
@slifty slifty added this to Phase 5 Sep 24, 2024
@slifty slifty moved this to Todo in Phase 5 Oct 1, 2024
@slifty slifty changed the title Expect loading an org or CM by taxId to be many, not one Expect loading a changemaker by taxId to be many, not one Nov 19, 2024
@slifty slifty moved this from Todo to Later in Phase 5 Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Phase 5
Status: Later
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bickelj