Add Keycloak organization UUID to data providers #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Broaden the scope of the KeycloakId to allow it to be a Keycloak UUID for either a Keycloak user or a Keycloak organization. Issue #1291
Given that an organization might exist in Keycloak prior to the introduction of the data provider row here or vice versa, we intend to support setting the Keycloak organization ID optionally. This change allows the software to defer linking a PDC Keycloak organization to a PDC service data provider until both exist. This commit does not make use of the Keycloak organization UUID but allows the software to store it and make use of it for data providers. Issue #1291
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1373 +/- ##
==========================================
- Coverage 87.34% 87.18% -0.17%
==========================================
Files 185 185
Lines 2387 2396 +9
Branches 314 326 +12
==========================================
+ Hits 2085 2089 +4
+ Misses 302 281 -21
- Partials 0 26 +26 ☔ View full report in Codecov by Sentry. |
|
@slifty Obviously it needs tests and expansion to funders and changemakers, but I wanted your opinion on this before making those changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that an organization might exist in Keycloak prior to the introduction of the data provider row here or vice versa, we intend to support setting the Keycloak organization ID optionally. This change allows the software to defer linking a PDC Keycloak organization to a PDC service data provider until both exist.